Skip to content

Conversation

@isaacbrodsky
Copy link
Collaborator

Attempting to build a workaround for #123 where we instead assemble the final built JAR from artifacts built in the Github Actions pipeline.

@coveralls
Copy link

coveralls commented Jan 29, 2023

Pull Request Test Coverage Report for Build #365

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.796%

Totals Coverage Status
Change from base Build #351: 0.0%
Covered Lines: 489
Relevant Lines: 490

💛 - Coveralls

Copy link
Contributor

@nrabinowitz nrabinowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, though there are some chunks I don't have a lot of expertise in.

@isaacbrodsky isaacbrodsky merged commit 321a3f5 into uber:master Jan 30, 2023
@isaacbrodsky isaacbrodsky deleted the upload-artifacts branch January 30, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants