Fix test compatibility with fonttools splitCubicAtT precision improvement#70
Merged
anthrotype merged 2 commits intomasterfrom Jan 15, 2026
Merged
Conversation
fonttools improved splitCubicAtT to ensure the first segment starts exactly at pt1 and the last segment ends exactly at pt4, eliminating floating point drift (e.g. 250.00000000000003 -> 250.0). Regenerated expected output for Q and QTail_reversed glyphs across all boolean operation layers (union, difference, intersection, xor).
Allow minor floating point differences when comparing glyph digests. This ensures tests pass with both older fonttools versions (which had floating point drift in splitCubicAtT) and newer versions (which force exact endpoint matching). Uses math.isclose for float comparison within a recursive helper that handles the nested digest structure.
Owner
|
thanks! I assume this should fix: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fonttools fonttools/fonttools#3743 added a fix to splitCubicAtT that ensures the first segment starts exactly at pt1 and the last segment ends exactly at pt4, eliminating floating point drift (e.g. 250.00000000000003 → 250.0).
The booleanOperations tests were comparing glyph digests exactly, so the cleaner output from the fixed splitCubicAtT caused test failures.
I regenerated expected test data to match the latest fonttools but also changed digest comparison to use math.isclose for floats, allowing the tests to pass with both old and new fonttools versions.