Remove wheel from setup_requires#63
Merged
anthrotype merged 1 commit intotypemytype:masterfrom Aug 3, 2021
Merged
Conversation
When downloading the source and building this locally python-wheel is not required. It is only required for developers who build bdist packages for publishing. The CI jobs that do this already manually install wheel anyway and most documentation I see assumes that will be the case. For distro packagers, having this in here just means we have to include an unused dependency or patch it out.
Contributor
Author
|
Alternatively it's possible that something like this conditional is the proper fix. I'll leave that to somebody that knows Python, but I'm happy to update this PR if a different implementation is desired. |
Collaborator
|
thanks. I hope you don't mind, but I am not going to cut a new release just for this. |
Owner
|
probably unrelated https://ci.appveyor.com/project/typemytype/booleanoperations/builds/40233845 |
Contributor
Author
|
Sure, I already patched for one release I'll just drop the patch on the next one. |
Collaborator
I don't think it's related |
This was referenced Aug 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When downloading the source and building this locally python-wheel is not required. It is only required for developers who build bdist packages for publishing. The CI jobs that do this already manually install wheel anyway and most documentation I see assumes that will be the case. For distro packagers, having this in here just means we have to include an unused dependency or patch it out.