ignore zero area contours only when pyclipper cannot add them#51
Merged
anthrotype merged 6 commits intomasterfrom Dec 10, 2018
Merged
ignore zero area contours only when pyclipper cannot add them#51anthrotype merged 6 commits intomasterfrom
anthrotype merged 6 commits intomasterfrom
Conversation
typemytype
changed the title
Owner
Author
|
test fails cause difference and xor are NOT working properly (testing now) |
to much copy paste...
drawbot scripts
typemytype
changed the title
Owner
Author
|
all fixed now |
pyclipper fails on empty paths
Owner
Author
|
I dont now what adding a check for bounds does for performance... but since the last version of pyclipper this raises an error. Previous versions simple ignores empty clipper paths. |
Owner
Author
|
a quick performance test: https://gist.github.com/typemytype/4ad64ad5d4f72b6662d74f418cd67c44 the timeit result are to close to each other (they both win once in a while) to speak of a performance dip. |
Collaborator
|
Thanks @typemytype |
This was referenced Dec 10, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this solves zero area self intersection paths, but still ignores reall zero area paths like lines
#50
#48