Update Scala, test & plugin libraries, then fixed code warnings#659
Closed
cordinc wants to merge 2 commits intotypelevel:masterfrom
Closed
Update Scala, test & plugin libraries, then fixed code warnings#659cordinc wants to merge 2 commits intotypelevel:masterfrom
cordinc wants to merge 2 commits intotypelevel:masterfrom
Conversation
Author
|
This was failing some CI tests that I didn't see when I was changing the code and running "sbt test publishLocal", but appeared when this request was submitted. So I closed it. My apologies, "works on my machine" is not very helpful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed a 0.5 scala native version of squants. After doing that I also updated the version of scala, sbt and other libraries to their most recent version. That created a bunch of deprecated warnings, so I changed the code as suggested in the warnings to remove them. I published the artifacts locally so I'm happy, but I thought maybe the changes would be useful upstream.