Add support for long in schema_builder #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylertreat
reviewed
Mar 7, 2017
bigquery/schema_builder.py
Outdated
|
|
||
| t = type(o) | ||
| if t == int: | ||
| if t == int or t == long: |
Owner
There was a problem hiding this comment.
This doesn't work in python 3 (http://python3porting.com/differences.html#long), which is why CI failed. Probably should do a check using six similar to the one below using six.integer_types (https://pythonhosted.org/six/#six.integer_types).
tylertreat
reviewed
Mar 7, 2017
bigquery/schema_builder.py
Outdated
|
|
||
| t = type(o) | ||
| if t == int: | ||
| if isinstance(t, six.integer_types): |
Owner
There was a problem hiding this comment.
Since t is a type, I don't think this is quite right. I believe this just needs to be if t in six.integer_types since six.integer_types is a tuple containing all integer types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the data that I have been dealing with had fields that were getting converted to long datatypes by Python, which were getting ignored/throwing an error when attempting to build a schema. This should now return "integer" when a long is passed to the function