Allow dl, dt and dd in sanitizer#39376
Merged
julien-deramond merged 2 commits intotwbs:mainfrom Nov 15, 2023
Merged
Conversation
These are inoffensive regular elements, along the same lines as ol/ul with li.
Member
|
Can't think of any reason to not include them. Thoughts @XhmikosR @GeoSot? Or @julien-deramond? |
mdo
approved these changes
Nov 13, 2023
Member
mdo
left a comment
mdo
left a comment
There was a problem hiding this comment.
Approving conditionally while waiting on feedback.
julien-deramond
approved these changes
Nov 14, 2023
Member
julien-deramond
left a comment
julien-deramond
left a comment
There was a problem hiding this comment.
Agreed, can't think of a reason to not include them.
I've found this draft W3C Standard Proposal > HTML Sanitizer API where there's a section named The Baseline Element Allow List. These elements are mentioned in it too.
romankupchak93
pushed a commit
to romankupchak93/bootstrap
that referenced
this pull request
Jan 5, 2024
Co-authored-by: Julien Déramond <juderamond@gmail.com>
This was referenced May 19, 2024
This was referenced May 24, 2024
This was referenced Oct 2, 2024
This was referenced Oct 5, 2024
This was referenced Oct 12, 2024
This was referenced Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
These are inoffensive regular elements, along the same lines as ol/ul with li. Overriding the defaults for that seems silly.
Type of changes
(I guess it's somewhere in the middle.)
Checklist
npm run lint)Live previews
Related issues
#33827