Selector Engine: fix multiple IDs

[GeoSot]

Description

Motivation & Context

A draft solution, which supports multiple ids, and usage off CSS.escape at the same time

Type of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Refactoring (non-breaking change)
• Breaking change (fix or feature that would change existing functionality)

Checklist

• I have read the contributing guidelines
• My code follows the code style of the project (using npm run lint)
• My change introduces changes to the documentation
• I have updated the documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed

Live previews

• https://deploy-preview-39201--twbs-bootstrap.netlify.app/

Related issues

Ref: #38989 , #339198

closes: #39189

[julien-deramond]

I haven't checked everything in detail but I was thinking about the same kind of patch when I tried to analyse the issue.
Your patch fixes the issue, and the multiple target ids system is still working.

Ideas of improvement:

• Add a new test with a multiple target ids containing special chars; something like the following:

    it('should get elements if several ids with special chars are given', () => {
      fixtureEl.innerHTML = [
        '<div id="test" data-bs-target="#j_id11:exampleModal,#j_id22:exampleModal"></div>',
        '<div class="target" id="j_id11:exampleModal"></div>',
        '<div class="target" id="j_id22:exampleModal"></div>'
      ].join('')

      const testEl = fixtureEl.querySelector('#test')

      expect(SelectorEngine.getMultipleElementsFromSelector(testEl)).toEqual(Array.from(fixtureEl.querySelectorAll('.target')))
    })

• Add other tests with weird authorized characters as IDs to check that the selector engine escapes the special chars when needed. If I understand well the HTML 5 spec, it seems that almost all characters are authorized except spaces in IDs.
  • Note: not for this PR but maybe in the future we should change the separator for data-bs-target (with multiple targets) to replace , which seems to be authorized as a character in IDs.

FWIW, it doesn't seem that #39198 is linked to this regression and is rather linked to some bad usage + a possible missing escape of characters in scrollspy's JS with anchors. So another topic.

[julien-deramond]

LGTM as explained in #39201 (review).

I've added an unit test for SelectorEngine too via e9c649b. Feel free to revert this commit if you don't agree with this approach.

@XhmikosR and/or @GeoSot, I let you double-check this fix in depth and determine if we need to release it in v5.3.3 soon.