Docs: add missing aria-disabled='true' to disabled anchors#38827
Merged
Conversation
Member
|
👀 |
Member
|
wonder if we should also give them all |
patrickhlauke
approved these changes
Jun 26, 2023
Contributor
|
FWIW if they don't have I think Regarding the linked comments, docs could also be clearer I gues? |
Member
|
@ffoodd oops, of course you're right. I just looked at the very first one (indeed the tab example) when I said about |
Member
There was a problem hiding this comment.
Wondering if we should add it for pagination as well (disabled class is on the parent but link are still dsiabled to me). Link here
Otherwise, seems fine to me.
This was referenced May 19, 2024
This was referenced May 24, 2024
This was referenced May 24, 2024
This was referenced Sep 18, 2024
This was referenced Sep 24, 2024
This was referenced Sep 28, 2024
This was referenced Sep 30, 2024
This was referenced Oct 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #38765 (comment) and #38765 (comment), this PR adds
aria-disabled="true"to all<a>s with.disabledclass. This is a follow-up to #38765.Hope these use cases all needed
aria-disabled="true".Type of changes
Checklist
npm run lint)Live previews
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/components/card/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/components/dropdowns/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/components/list-group/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/components/navbar/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/components/navs-tabs/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/components/card/placeholders/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/blog/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/blog-rtl/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/carousel/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/carousel-rtl/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/cheatsheet/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/cheatsheet-rtl/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/navbar-bottom/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/navbar-fixed/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/navbar-static/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/navbars/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/sticky-footer-navbar/
Related issues
#38765