Docs: add missing twbs/examples and change sorting#38407
Conversation
| indexPath: src/pages/index.tsx | ||
| - name: Bootstrap with Vue | ||
| description: "Import and bundle Bootstrap's source Sass and JavaScript with Vue and Vite." | ||
| url: /examples/tree/main/vue |
There was a problem hiding this comment.
Maybe we should sort these a little different? I feel the current sorting is a little weird, but I don't know if sorting by name in the template would make sense. Maybe a manual sorting would be better?
There was a problem hiding this comment.
Yeah I didn't understand the original order when I added the new examples so I've put them in the end. I agree that it can be improved but IDK know how exactly. If we don't find any idea or logic to sort them, maybe the right thing to do is to do it alphabetically.
If you have any ideas, you can commit them directly. I'll try to think about it too.
There was a problem hiding this comment.
Better IMO. Maybe we can also remove the "Bootstrap with " prefixes. Not sure there are useful for readability.
There was a problem hiding this comment.
Oh yeah or putting it everywhere like you did. One or the other no problem
There was a problem hiding this comment.
I kept the same sorting we have in https://github.com/twbs/examples#readme
There was a problem hiding this comment.
Good idea. LGTM 👌
XhmikosR
changed the title
XhmikosR
changed the title
twbs/examples and change sorting
2 participants
Description
This PR adds missing twbs/examples in our /examples page.
In order to do that, because of the
src/pages/index.tsxmain file, I've modified the/examples/_index.mdfile to directly set the index path fromsite/data/examples.ymlfile.It also adds some callouts:
Motivation & Context
Let the users know that we have a lot of examples.
Type of changes
Checklist
npm run lint)Live previews
Related issues
Closes #38370