Skip to content

Change diff file path in Webpack guide#38339

Merged
XhmikosR merged 1 commit intomainfrom
main-jd-fix-diff-webpack-guide
Mar 27, 2023
Merged

Change diff file path in Webpack guide#38339
XhmikosR merged 1 commit intomainfrom
main-jd-fix-diff-webpack-guide

Conversation

@julien-deramond
Copy link
Copy Markdown
Member

@julien-deramond julien-deramond commented Mar 27, 2023

Description

This PR contains a small fix to use the same reference for the diff in the Webpack guide.
When we follow the tutorial, we are in the my-project directory, so when we are doing the diffs, it is in this directory and not in a webpack directory (as in twbs/examples).

There are no diffs in Parcel and Vite guides so this is the only place where a modification is needed.

Motivation & Context

Consistency between diffs in this guide.

Type of changes

  • Enhancement (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@XhmikosR XhmikosR merged commit 2bbf670 into main Mar 27, 2023
@XhmikosR XhmikosR deleted the main-jd-fix-diff-webpack-guide branch March 27, 2023 08:04
@XhmikosR XhmikosR added the skip-changelog So that the release drafter action doesn't include it label Mar 31, 2023
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs skip-changelog So that the release drafter action doesn't include it v5

Projects

No open projects
Status: Needs review

Development

Successfully merging this pull request may close these issues.

2 participants