Skip to content

Docs: fix two class attributes on same button#38317

Merged
XhmikosR merged 2 commits intotwbs:mainfrom
hannahiss:main-his-class-bug
Mar 24, 2023
Merged

Docs: fix two class attributes on same button#38317
XhmikosR merged 2 commits intotwbs:mainfrom
hannahiss:main-his-class-bug

Conversation

@hannahiss
Copy link
Copy Markdown
Contributor

@hannahiss hannahiss commented Mar 24, 2023

Description

Remove redundant class attribute on button in javascript.md html code example

Motivation & Context

Remove redundant class attribute to make example correct

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@hannahiss hannahiss marked this pull request as ready for review March 24, 2023 10:46
Copy link
Copy Markdown
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@XhmikosR XhmikosR merged commit 2008c65 into twbs:main Mar 24, 2023
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants