Another pass at fixing floating labels disabled colors#38313
Merged
Conversation
This was referenced Mar 24, 2023
Contributor
|
unfortunately does not work in textarea without the form-floating-label-height after the height adjustment
|
Member
Author
|
Pushed another commit to fix that. |
mdo
force-pushed
the
yet-another-ff-label-fix
branch
from
a55f824 to
840557b
Compare
Contributor
|
the label can be across the entire width and at the very top. |
Member
Author
|
I didn't take the label all the way to the top because it can interfere with the shadow when shadows are enabled. Full width or auto width could be possible, will have to experiment. |
mdo
force-pushed
the
yet-another-ff-label-fix
branch
from
840557b to
5e14483
Compare
Contributor
|
this looks😎 good to me 👌 |
Member
Author
|
This fixes a few things for us, so going to merge as-is and we can ship and iterate. |
3 tasks
6 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternate fix to #38159.
Will need to deprecate the
$form-floating-label-heightvariable with this solution, or use it some other way, but it works without using the:has()selector. Approach here remaps theopacityvalue to anrgba()alpha channel, so we can just style based on background or a generated element. With this we could probably simplify more, but open to ideas.