Conversation
Member
|
There's a balance between everything and some things might make more sense to keep them simple :) Even if the index.html is not found, StackBlitz redirects so it's sort of OK. That being said, I don't mind with the current solution for now, but you need to escape any characters and construct the URL param automatically not manually ( |
mdo
approved these changes
Mar 24, 2023
9a4395a to
6c8e429
Compare
XhmikosR
approved these changes
Mar 24, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some links in https://twbs-bootstrap.netlify.app/docs/5.3/examples/ redirect to the right StackBlitz environment, but not always directly to the
index.htmlwhich can be insrcdirectory.This PR shows a way to fix it. It might over-complexify the algorithm.
3 possibilities:
/instead of/index.htmlwhich will point out to theREADME.mdand it would be valid for each environment./cc @XhmikosR
Type of changes
Checklist
npm run lint)Live previews