Skip to content

Fix reference to twbs/examples/icons-font + fine-tune index.html SB location target#38310

Merged
XhmikosR merged 6 commits intomainfrom
main-jd-fix-url-to-index.html-in-starters-examples
Mar 24, 2023
Merged

Fix reference to twbs/examples/icons-font + fine-tune index.html SB location target#38310
XhmikosR merged 6 commits intomainfrom
main-jd-fix-url-to-index.html-in-starters-examples

Conversation

@julien-deramond
Copy link
Copy Markdown
Member

@julien-deramond julien-deramond commented Mar 23, 2023

Description

Some links in https://twbs-bootstrap.netlify.app/docs/5.3/examples/ redirect to the right StackBlitz environment, but not always directly to the index.html which can be in src directory.

Screenshot 2023-03-23 at 15 55 33

This PR shows a way to fix it. It might over-complexify the algorithm.
3 possibilities:

  • this PR is OK
  • we don't care and keep the current situation not perfect
  • we choose to link to / instead of /index.html which will point out to the README.md and it would be valid for each environment.

⚠️ This PR also fixes the link to the "Bootstrap Icons" correct StackBlitz environment. It might be treated in another PR if needed.

/cc @XhmikosR

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review March 23, 2023 15:02
@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Mar 23, 2023

There's a balance between everything and some things might make more sense to keep them simple :)

Even if the index.html is not found, StackBlitz redirects so it's sort of OK. That being said, I don't mind with the current solution for now, but you need to escape any characters and construct the URL param automatically not manually (/ should be %2F).

@XhmikosR XhmikosR marked this pull request as draft March 24, 2023 06:04
@julien-deramond julien-deramond force-pushed the main-jd-fix-url-to-index.html-in-starters-examples branch from 9a4395a to 6c8e429 Compare March 24, 2023 13:48
@XhmikosR XhmikosR marked this pull request as ready for review March 24, 2023 13:59
@XhmikosR XhmikosR merged commit 0653e7f into main Mar 24, 2023
@XhmikosR XhmikosR deleted the main-jd-fix-url-to-index.html-in-starters-examples branch March 24, 2023 14:01
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants