Docs: make all headings use var(--bs-emphasis-color)#38262
Merged
Conversation
mdo
reviewed
Mar 17, 2023
julien-deramond
force-pushed
the
main-jd-fix-docs-headers-in-white
branch
from
b47a92d to
1de72bd
Compare
julien-deramond
force-pushed
the
main-jd-fix-docs-headers-in-white
branch
from
1de72bd to
5b28563
Compare
mdo
approved these changes
Mar 18, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the main branch, headings of the homepage are all grays:
But this is not the case for the
/docsand/examplespages.This PR suggests using
var(--bs-emphasis-color)in .bd-masthead and .masthead-followup headings.Note: no change of color for the footer headings.
Type of changes
Checklist
npm run lint)Live previews