Fix wrong generation of aria-labelledby in tab navigation#38223
Merged
Fix wrong generation of aria-labelledby in tab navigation#38223
aria-labelledby in tab navigation#38223Conversation
aria-labelledby in tab navigation
XhmikosR
approved these changes
Mar 14, 2023
Member
|
Thanks for the PR! Good catch, because the test was also wrong so it was harder to spot. For future reference it seems this was broken in 135b9cd#diff-6090db9da36e79f2e879e6d5232960d82d60af6017a0297d6c500c7cdb5953a1R221 |
Contributor
Author
|
Thanks for the quick approval. And sorry that I missed the test case! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wrong autogeneration of aria-labelledby in tab navigation.
Fixes #38222
Type of changes
Checklist
npm run lint)Related issues
Fixes #38222