Skip to content

Icon link: envariable + enhance the documentation#38130

Merged
mdo merged 3 commits intomainfrom
main-lmp-icon-link-enhancement
Mar 2, 2023
Merged

Icon link: envariable + enhance the documentation#38130
mdo merged 3 commits intomainfrom
main-lmp-icon-link-enhancement

Conversation

@louismaximepiton
Copy link
Copy Markdown
Member

@louismaximepiton louismaximepiton commented Feb 28, 2023

Description

Introduce some Sass variables to better handle the default .icon-link.
Adding some docs about this variables and display some ways to custom those links.
Add fill: currentcolor for icons.

Motivation & Context

Better customization for end users.
Adding some CSS that comes from the docs CSS atm.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

NA

Copy link
Copy Markdown
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! <3

@mdo mdo merged commit 7832136 into main Mar 2, 2023
@mdo mdo deleted the main-lmp-icon-link-enhancement branch March 2, 2023 18:32
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants