Fix button visibility issue on dark theme#38115
Merged
Conversation
Member
louismaximepiton
left a comment
louismaximepiton
left a comment
There was a problem hiding this comment.
Hey, nice catch!
Just a small enhancement and I think we're good to go. Thanks a lot for your PR 😄
…text-visible-in-dark-mode
Contributor
Author
|
@louismaximepiton Moved color to sass variable! |
mdo
approved these changes
Mar 2, 2023
Member
mdo
left a comment
mdo
left a comment
There was a problem hiding this comment.
Two quick changes I'll make and then good to go, thanks!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix button color change issue on switching to dark theme: Resolved an issue where the button color was not changing properly on switching to the dark theme.
Type of changes
Checklist
npm run lint)Related issues
Closes #38113