Conversation
julien-deramond
left a comment
julien-deramond
left a comment
There was a problem hiding this comment.
Few quick comments. I haven't done the complete review, I'll continue later.
site/content/docs/5.3/examples/dashboard-rtl/index.html and site/content/docs/5.3/examples/blog-rtl/index.html should be updated as well to reflect site/content/docs/5.3/examples/dashboard/index.html and site/content/docs/5.3/examples/blog/index.html modifications.
mdo
force-pushed
the
more-darkmode-examples
branch
from
b987bf1 to
3babf1e
Compare
![github-advanced-security[bot]](https://waps.l3s.uni-hannover.de/live/im_/https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Minimal modifications have been done for |
|
The same work has been done for |
|
Global comment to take into account here or in a separate PR: because of If done here, #38512 can be closed. |
mdo
force-pushed
the
more-darkmode-examples
branch
from
4fca984 to
c9e57bc
Compare
* WIP darkmode examples * Fix product css error, redo parts of blog * wip dashboard * updated rtl generated * fix up some examples, namely dashboard * jumbotron and sign-in fixes * more fixes * more * Fixes from code review * Remove duplicate `data-bs-target` in dashboard/index.html * Modify `blog-rtl/index.html` * Modify `dashboard-rtl/index.html` * Modify `carousel-rtl/index.html` * Keep JS on all pages for switcher * Remove Feather from dashboard examples --------- Co-authored-by: Julien Déramond <juderamond@gmail.com>
3 participants
Tackles a few more examples. Thought I opened this previously, but apparently not.