unify offcanvas keydown event logic with modal#38025
Merged
julien-deramond merged 2 commits intotwbs:mainfrom Feb 11, 2023
Merged
unify offcanvas keydown event logic with modal#38025julien-deramond merged 2 commits intotwbs:mainfrom
offcanvas keydown event logic with modal#38025julien-deramond merged 2 commits intotwbs:mainfrom
Conversation
10 tasks
GeoSot
reviewed
Feb 8, 2023
Ronid1
force-pushed
the
ronid1/offcanvas_refactor
branch
from
680e046 to
a34b06f
Compare
Contributor
Author
|
@GeoSot updated according to your review. Rebased and squashed. |
XhmikosR
changed the title
offcanvas keydown event logic with modaloffcanvas keydown event logic with modal
GeoSot
approved these changes
Feb 10, 2023
GeoSot
force-pushed
the
ronid1/offcanvas_refactor
branch
from
a34b06f to
7eff064
Compare
Member
|
It looks fin to my eyes. note: I suppose we don't need any tests for this |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since the
offcanvaskeydownevent listener behaves like themodalkeydownlistener, the former was refactored like themodal. Making it more readable by using positive conditions instead of negative ones.Motivation & Context
To make refactor and bugfix separated, a new PR was opened as discussed in this comment.
Type of changes
Checklist
npm run lint)Live previews
N/A
Related issues
Splited from #37968