Skip to content

Fix list group colors by using *-text-emphasis CSS vars in Sass loop#38008

Merged
julien-deramond merged 1 commit intomainfrom
main-jd-fix-listgroup-variant-colors
Feb 6, 2023
Merged

Fix list group colors by using *-text-emphasis CSS vars in Sass loop#38008
julien-deramond merged 1 commit intomainfrom
main-jd-fix-listgroup-variant-colors

Conversation

@julien-deramond
Copy link
Copy Markdown
Member

@julien-deramond julien-deramond commented Feb 6, 2023

Description

Change the list group text color to *-text-emphasis to fix variant colors not applied.

Motivation & Context

List group text colors need the same update as in #38003 for the same reason as it can be seen in https://twbs-bootstrap.netlify.app/docs/5.3/components/list-group/#variants.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (N/A) My change introduces changes to the documentation
  • (N/A) I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review February 6, 2023 11:48
@julien-deramond julien-deramond requested a review from a team as a code owner February 6, 2023 11:48
@julien-deramond julien-deramond merged commit cbc4e3a into main Feb 6, 2023
@julien-deramond julien-deramond deleted the main-jd-fix-listgroup-variant-colors branch February 6, 2023 12:08
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants