Docs: add explanation of the base .btn class#37275
Merged
patrickhlauke merged 12 commits intomainfrom Jan 3, 2023
Merged
Conversation
and a callout reminding authors to at least define some focus styling if they intend to use it "naked"
Member
julien-deramond
left a comment
julien-deramond
left a comment
There was a problem hiding this comment.
This explanation looks good to me and explain well what are "naked" buttons and how they look like. It will help with non-regression testing.
@mdo I let you check it too
julien-deramond
approved these changes
Oct 11, 2022
XhmikosR
reviewed
Oct 25, 2022
Member
Author
|
@mdo when you get a moment, could you give this a thumbs up or down? |
Member
Author
|
Going to be so bold as to merge it, as there doesn't seem to be any further feedback on it |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed recently in the team slack, this adds an initial explanation of the intention behind the basic
.btnclass - as a starting point for either using the extra predefined styles, or for an author's own stylings.Also adds a callout reminding authors to at least define some focus styling if they intend to use it "naked".
Motivation & Context
We're often seeing authors using just
.btn, and this "naked" use is not actually documented/explained anywhere. Also, authors then forgetting to create focus styles causes accessibility issues further down the line if they're not expecting it. We may decide in future to still add some absolutely basic focus styling, just in case, but this would be a breaking change for the next minor release/Live previews