Fix WebApp.requestContact typing #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valid-var
approved these changes
Mar 2, 2024
valid-var
left a comment
valid-var
left a comment
There was a problem hiding this comment.
According to
https://github.com/twa-dev/SDK/blob/45b54230902e36f4deeaaeeb140559008e82d0f4/src/telegram-web-apps.js#L1236
And data receiving from api
Changes are correct
Member
|
Hello. Thanks for MR. Please update your branch to fix conflicts |
Member
|
@wishyoudie Please update your branch to fix conflicts |
Contributor
Author
|
Hey @ArthurStam! Just updated the PR, hope this helps. Sorry for the long wait! |
ArthurStam
approved these changes
Jan 4, 2025
Member
|
Merged, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong typing for
WebApp.requestContactmethod. Provided type requires callback of type(access: boolean) => unknownmeanwhile
(access: boolean, result: ???) => unknownworks just fine with result of method call in
resultfield.