Implement arbitrary expression evaluation in RETURN projections#360
Closed
cyrusknopf wants to merge 53 commits intomainfrom
Closed
Implement arbitrary expression evaluation in RETURN projections#360cyrusknopf wants to merge 53 commits intomainfrom
cyrusknopf wants to merge 53 commits intomainfrom
Conversation
cyrusknopf
force-pushed
the
v2/return-expr
branch
from
c73d122 to
40d6923
Compare
cyrusknopf
force-pushed
the
v2/return-expr
branch
from
693fbe3 to
38d55ae
Compare
rjb32
reviewed
Feb 2, 2026
query/plan/PipelineGenerator.cpp
Outdated
|
|
||
| ExprProgram* prog = ExprProgram::create(_pipeline); | ||
| ExprProgramGenerator progGen = | ||
| ExprProgramGenerator(this, prog, _builder.getPendingOutput()); |
Contributor
There was a problem hiding this comment.
Why not just use the constructor? Like:
ExprProgramGenerator progGen(this, prog, _builder.getPendingOutput());
rjb32
reviewed
Feb 3, 2026
| throwError("Return statement without previous node", stmt); | ||
| } | ||
| // A "standalone return" is a sole return clause, e.g. `RETURN 4 + 5` | ||
| const bool isStandaloneReturn = prevNode == nullptr; |
Contributor
There was a problem hiding this comment.
Please add parenthesis around the boolean expression for readability
Contributor
|
Otherwise looks good to me, it's well commented |
Contributor
Author
|
Moved to #407 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #359