change fixed-pedigree example fixes #2 #2447
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2447 +/- ##
=======================================
Coverage 91.22% 91.22%
=======================================
Files 20 20
Lines 11847 11847
Branches 2300 2300
=======================================
Hits 10807 10807
Misses 569 569
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jeromekelleher ready for review |
|
We don't want to change the existing example, it's doing it's job fine. We want a new example, just to illustrate this particular issue. |
|
Aw ok. Sorry, my bad |
hossam26644
force-pushed
the
fix/ancestry-pedigree-example-2440
branch
from
18f0647 to
c528755
Compare
|
@jeromekelleher check if this does the job |
hossam26644
force-pushed
the
fix/ancestry-pedigree-example-2440
branch
from
c528755 to
f67ca5b
Compare
revert fixed pedigree example update text
jeromekelleher
force-pushed
the
fix/ancestry-pedigree-example-2440
branch
from
f67ca5b to
9f13711
Compare
|
I've pushed a commit changing to a simpler example - can you review to see if I've made any mistakes please? |
| pedigree = msprime.parse_pedigree(io.StringIO(ped_txt), sequence_length=100) | ||
| ped_ts = msprime.sim_ancestry( | ||
| initial_state=pedigree, |
There was a problem hiding this comment.
I suggest you move the simulations block to the next code block
| share a common ancestor, which defines the **SMC′** model. Simulating under the Hudson | ||
| coalescent model is equivalent to setting the ```hull_offset``` to the sequence length. The | ||
| The {class}`SMC(k) <.SmcKApproxCoalescent>` model is a general simulations model that can simulate various **SMC** approximations | ||
| (e.g., **SMC** and **SMC′**). It accepts a ```hull_offset``` parameter, which defines the extent of |
There was a problem hiding this comment.
you are removing trailing white spaces from different lines. Is this intentional?
There was a problem hiding this comment.
As I explained in another PR, this is because my editor is configured to automatically trim whitespace. The issue here is that your editor isn't set up to do this, and we're not enforcing lint checking on markdown files.
|
Looks good. Sorry you had to do it yourself! |
jeromekelleher
force-pushed
the
fix/ancestry-pedigree-example-2440
branch
from
9f13711 to
3720520
Compare
2 participants
fixes #2440