Skip to content

Preparation for v08 of RFC8776-bis#252

Merged
italobusi merged 10 commits intotsaad-dev:masterfrom
italobusi:8776-bis-08
Jan 29, 2024
Merged

Preparation for v08 of RFC8776-bis#252
italobusi merged 10 commits intotsaad-dev:masterfrom
italobusi:8776-bis-08

Conversation

@italobusi
Copy link
Collaborator

@italobusi italobusi commented Nov 17, 2023

Updated TE packet types module description: fix #250

Updated TE packet types to support (full) LSP re-routing: see #243

  • obsoleted identity lsp-protection-reroute-extra;
  • obsoleted identity lsp-protection-reroute;
  • added identity restoration-scheme-rerouting.

Updated path metric types: see #103:

  • moved identity path-metric-loss from ietf-te-mpls to ietf-te-packet-types;
  • added identity path-metric-delay-varation to ietf-te-packet-types;
  • clarified that derived identities from path-metric-type should describe the unit and maximum value of the associated path metric.

Updated typedef te-node-id to add support also for 16 octects TE identifiers (formatted as IPv6 addresses): fix #129

Container explicit-route-objects-always renamed as explicit-route-objects: fix #254

Updated TE packet types module description: fix tsaad-dev#250
Added support for (full) LSP re-routing: see tsaad-dev#243
- obsoleted identity lsp-protection-reroute-extra;
- obsoleted identity lsp-protection-reroute;
- added identity restoration-scheme-rerouting.
Updated path metric types: see tsaad-dev#103:
- moved identity path-metric-loss from ietf-te-mpls to ietf-te-packet-types;
- added identity path-metric-delay-varation to ietf-te-packet-types.

Few doubts raised in tsaad-dev#103 (comment)
Clarify that derived identities from path-metric-type should describe the unit and maximum value of the associated path metric: see tsaad-dev#103
@italobusi italobusi changed the title Preparation for v03 of RFC8776-bis Preparation for v08 of RFC8776-bis Nov 17, 2023
base restoration-scheme-type;
description
"Restoration LSP is computed after the failure detection.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why empty line?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having empty lines between different paragraphs in the description is usually easier to read

description
"The path delay variation encodes the sum of the unidirectional
delay variation metrics of all links traversed by a P2P path.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the above statement is correct. "The path delay variation is not sum of individual delay variation".

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to use delay variation (DV) as a bound on per link DV.. So, computation can prune links that exceeds the DV bound?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the definition I have found in RFC8233

base path-metric-type;
description
"The path loss (as a packet percentage) metric type
encodes a function of the unidirectional loss metrics of all
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can loss be used as a bound? e.g. to prune links that exceed loss of 5%?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that in the ietf-te this is used as a path-metric and not as a link-metric ...

// CHANGE NOTE: The identity path-metric-loss below has
// been added in this module revision
// RFC Editor: remove the note above and this note
identity path-metric-loss {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking a bit, why do we want to prepend "path-" to metric type?
Ideally, it is simply metric-type and this can be per link or per path metric type.
There are cases were we can set a bound applicable on per link (e.g. loss, DV, etc.) and other cases where metric is end-to-end.. I'd think where the metric leaf is will tell if per link or per path.

What do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you, but I am a bit worried about the side effects

RFC8776 has already defined the base identity as path-metric-type and used this naming convention for the derived identities

Also ietf-te is using these metric types for path metric bound and cumulative values

Added support also for 16 octects TE identifiers (formatted as IPv6 addresses): fix tsaad-dev#129
Container explicit-route-objects-always renamed as explicit-route-objects: fix tsaad-dev#254
@italobusi italobusi marked this pull request as ready for review January 25, 2024 17:09
@italobusi italobusi merged commit 8c78ba7 into tsaad-dev:master Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change name of container explicit-route-objects-always to explicit-route-objects TE Packet Types module description Support for IPv6

3 participants