chore: add automatic market settlement config

[MicBun]

resolves: https://github.com/truflation/website/issues/2921

Summary by CodeRabbit

• New Features

  • Introduced settlement extension automation with adjustable schedule, batch-size control, and configurable retry limits; feature is initially disabled by default.

• Chores

  • Added a persistent settlement configuration seeded with defaults and an index to speed up settlement candidate queries.
  • Default polling schedule changed to run hourly (on the hour).

• Tests

  • Updated integration test expectations and log messages to reflect config loaded from migration.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Adds Migration 039: creates a single-row settlement_config table for automatic settlement extension, seeds defaults, and adds an index for settlement candidate lookup; updates the default settlement polling schedule constant to run hourly.

Changes

Cohort / File(s)	Summary
Database Migration internal/migrations/039-settlement-extension.sql	Adds settlement_config table with columns id, enabled, settlement_schedule, max_markets_per_run, retry_attempts, updated_at; seeds row (1, false, '0 * * * *', 10, 3, 0); creates index idx_settlement_candidates on ob_queries(settled, settle_time).
Constants extensions/tn_settlement/constants.go	Changes DefaultSettlementSchedule from "*/5 * * * *" (every 5 minutes) to "0 * * * *" (every hour on the hour) and updates the comment.
Tests extensions/tn_settlement/settlement_integration_test.go	Adjusts test expectations/log message to reflect loading config from migration (schedule "0 * * * *", enabled=false, maxMarkets=10, retries=3).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Check migration SQL for correct column names and defaults (notably retry_attempts and updated_at type).
• Verify seeded values and cron expression align with the updated constant.
• Confirm index idx_settlement_candidates matches settlement query usage.

Possibly related PRs

• feat: automatic market settlement #1272 — Related main PR touching the settlement extension and the same default schedule and migration additions.

Suggested labels

type: chore

Suggested reviewers

• pr-time-tracker

Poem

🐰 I hopped through the schemas, planted a row so bright,
Hourly I wake to check markets through the night,
A tiny index scurries, seeds snug in the ground,
Retries set, schedule steady — settlements now found. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore: add automatic market settlement config' accurately describes the main changes: adding a settlement_config table and related configuration infrastructure for automatic market settlement.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch settleConfig

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b1aecd and 15b4657.

📒 Files selected for processing (3)

• extensions/tn_settlement/constants.go (1 hunks)
• extensions/tn_settlement/settlement_integration_test.go (1 hunks)
• internal/migrations/039-settlement-extension.sql (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• extensions/tn_settlement/constants.go
• internal/migrations/039-settlement-extension.sql

🧰 Additional context used

🧬 Code graph analysis (1)

extensions/tn_settlement/settlement_integration_test.go (1)

extensions/tn_settlement/internal/engine_ops.go (1)

• NewEngineOperations (31-38)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: acceptance-test

🔇 Additional comments (1)

extensions/tn_settlement/settlement_integration_test.go (1)

229-243: Migration and constants verified—all test expectations are correct.

The test properly validates that LoadSettlementConfig loads the migration-seeded settlement_config defaults. Migration 039 seeds all expected values:

• enabled = false (safety default)
• settlement_schedule = '0 * * * *' (hourly)
• max_markets_per_run = 10
• retry_attempts = 3

Constants.go correctly defines DefaultSettlementSchedule = "0 * * * *", matching the migration. All changes are consistent and correct.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[holdex]

Time Submission Status

Member	Status	Time	Action	Last Update
MicBun	✅ Submitted	5h	Update time	Dec 15, 2025, 1:45 PM

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

internal/migrations/039-settlement-extension.sql (1)

37-44: Consider adding CHECK constraints for integer field bounds.

The integer fields (max_markets_per_run, max_retries) lack CHECK constraints to ensure sensible values. Currently, a user could set these to 0 or negative values, which could cause unexpected behavior in the settlement extension.

Apply this diff to add defensive constraints:

 CREATE TABLE settlement_config (
     id INT PRIMARY KEY,
     enabled BOOLEAN DEFAULT false NOT NULL,
     settlement_schedule TEXT DEFAULT '*/5 * * * *' NOT NULL,
-    max_markets_per_run INT DEFAULT 10 NOT NULL,
-    max_retries INT DEFAULT 3 NOT NULL,
+    max_markets_per_run INT DEFAULT 10 NOT NULL CHECK (max_markets_per_run > 0),
+    max_retries INT DEFAULT 3 NOT NULL CHECK (max_retries >= 0),
     updated_at INT8 DEFAULT 0 NOT NULL
 );

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc1237f and 505ef2c.

📒 Files selected for processing (1)

• internal/migrations/039-settlement-extension.sql (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: lint
• GitHub Check: acceptance-test

🔇 Additional comments (2)

internal/migrations/039-settlement-extension.sql (2)

1-33: Excellent documentation and clear configuration design.

The migration provides comprehensive documentation with usage examples, dependencies, and operational guidance. The single-row table pattern with explicit defaults is appropriate for a configuration table, and defaulting to disabled ensures safe deployment.

---

56-57: The columns settled and settle_time exist on the ob_queries table. They are defined in migration 030-order-book-schema.sql as settled BOOLEAN DEFAULT false NOT NULL and settle_time INT8 NOT NULL, which runs before this migration. The index creation will succeed.

Likely an incorrect or invalid review comment.