Skip to content

chore(ci): increase test timeout to 30m#1264

Merged
MicBun merged 1 commit intomainfrom
choreMoreTimeCI
Nov 26, 2025
Merged

chore(ci): increase test timeout to 30m#1264
MicBun merged 1 commit intomainfrom
choreMoreTimeCI

Conversation

@MicBun
Copy link
Member

@MicBun MicBun commented Nov 26, 2025

related: #1237

Summary by CodeRabbit

  • Chores
    • Updated CI pipeline configuration paths to reflect project structure changes.
    • Increased Go test timeout threshold to allow for longer-running test execution.

✏️ Tip: You can customize this high-level summary in your review settings.

@MicBun MicBun self-assigned this Nov 26, 2025
@MicBun MicBun merged commit dfbdcba into main Nov 26, 2025
4 checks passed
@MicBun MicBun deleted the choreMoreTimeCI branch November 26, 2025 15:09
@coderabbitai
Copy link

coderabbitai bot commented Nov 26, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

CI workflow configuration updated to relocate cleanup script and Docker compose paths from node subdirectory to root level. Go test timeout for kwiltest increased from 15 minutes to 30 minutes. No behavioral changes to cleanup and retry logic.

Changes

Cohort / File(s) Summary
CI workflow path and timeout updates
\\.github/workflows/ci.yaml
Revised cleanup script path from node/scripts/ci-cleanup.sh to scripts/ci-cleanup.sh; updated Docker cleanup target from node/compose.yaml to compose.yaml; extended kwiltest Go test timeout from 15m to 30m

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Simple path corrections and single timeout adjustment
  • Low risk of unintended side effects due to straightforward configuration changes

Poem

🐰 Paths shift and timeouts grow wide,
The rabbit hops with cleanup in stride,
From nested nodes to root they flee,
Thirty minutes tests will be free!

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch choreMoreTimeCI

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 12e1de2 and 0e6d404.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@holdex
Copy link

holdex bot commented Nov 26, 2025

Time Submission Status

Member Status Time Action Last Update
MicBun ✅ Submitted 1h Update time Nov 26, 2025, 3:10 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant