chore: include blacklist update in binary#1104
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughDependency versions updated in go.mod across multiple modules; no source code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Time Submission Status
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
go.mod (1)
20-21: Prefer pinned release tags over pseudo-versions for reproducible buildsUsing pseudo-versions is fine short-term to ship the blacklist feature; consider cutting tags on kwil-db and kwil-db/core (e.g., v0.10.3+blacklist or the next semantic tag) and switching to them in a follow-up to avoid drift if the underlying commit gets rebased or superseded.
I can open a follow-up PR once the tags are cut.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod(5 hunks)
🔇 Additional comments (8)
go.mod (8)
7-26: Achieves objective: kwil-db/core bump will embed the blacklist update into the binaryThe direct upgrade to trufnetwork/kwil-db and core looks aligned with making the blacklist feature live in prod via binary rebuild.
25-25: Good upgrade: x/sync v0.15.0This brings in recent bug fixes and scheduler-aware primitives; low risk and beneficial.
92-92: logr v1.4.3 bump looks goodMinor patch; no breaking changes expected.
134-134: klauspost/compress v1.18.0 bump approvedPerformance and security improvements; no API break expected for indirect use.
223-227: Prometheus client and deps upgraded — LGTMThese versions are compatible and widely used; indirect only, so impact is minimal.
251-251: Core OpenTelemetry bump to v1.37.0 — LGTMBrings in recent fixes and features. Assuming tests are green (as noted), this should be safe.
Also applies to: 255-258
264-269: x/crypto, x/net, x/sys, x/term, x/text bumps — approvedSecurity and bug-fix updates; no code changes required here.
276-276: google.golang.org/protobuf v1.36.6 — approvedPatch-level update, safe and desirable.
Description
Related Problem
How Has This Been Tested?
all tests pass
Summary by CodeRabbit