Skip to content

chore: include blacklist update in binary#1104

Merged
MicBun merged 2 commits intomainfrom
chore/release-blacklist
Aug 15, 2025
Merged

chore: include blacklist update in binary#1104
MicBun merged 2 commits intomainfrom
chore/release-blacklist

Conversation

@outerlook
Copy link
Contributor

@outerlook outerlook commented Aug 15, 2025

Description

Related Problem

How Has This Been Tested?

all tests pass

Summary by CodeRabbit

  • Chores
    • Updated third-party libraries and SDKs to newer versions across networking, security, logging, compression, metrics/monitoring, and tracing.
    • Synchronized module versions and refreshed indirect dependencies.
    • No changes to application behavior, UI, or public interfaces.
    • Existing workflows remain the same; no user action required.

@outerlook outerlook self-assigned this Aug 15, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 15, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Dependency versions updated in go.mod across multiple modules; no source code or API changes.

Changes

Cohort / File(s) Summary
Dependencies
go.mod
Bumped versions for Kwil-DB/Core, golang.org/x/*, go-logr/logr, klauspost/compress, Prometheus packages, OpenTelemetry components, google.golang.org/protobuf, and other indirect deps. No code changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Assessment against linked issues

Objective Addressed Explanation
Blacklist feature live on Production (#1110) Only dependency updates; no blacklist feature implementation, config, or rollout changes.

Assessment against linked issues: Out-of-scope changes

Code Change Explanation
Dependency version bumps (go.mod) Not related to enabling or implementing the blacklist feature from #1110.

Poem

I nibbled through go.mod with care and delight,
Hopping past versions, making them right.
No code to refactor, no tests to amend—
Just fresher carrots for builds to depend.
Thump-thump! The garden compiles tonight. 🥕🐇

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/release-blacklist

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@outerlook outerlook requested a review from MicBun August 15, 2025 20:09
@holdex
Copy link

holdex bot commented Aug 15, 2025

Time Submission Status

Member Status Time Action Last Update
@outerlook ❌ Missing - ⚠️ Submit time -
MicBun ✅ Submitted 45min Update time Aug 15, 2025, 8:30 PM

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
go.mod (1)

20-21: Prefer pinned release tags over pseudo-versions for reproducible builds

Using pseudo-versions is fine short-term to ship the blacklist feature; consider cutting tags on kwil-db and kwil-db/core (e.g., v0.10.3+blacklist or the next semantic tag) and switching to them in a follow-up to avoid drift if the underlying commit gets rebased or superseded.

I can open a follow-up PR once the tags are cut.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between db6dad6 and fdf592a.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod (5 hunks)
🔇 Additional comments (8)
go.mod (8)

7-26: Achieves objective: kwil-db/core bump will embed the blacklist update into the binary

The direct upgrade to trufnetwork/kwil-db and core looks aligned with making the blacklist feature live in prod via binary rebuild.


25-25: Good upgrade: x/sync v0.15.0

This brings in recent bug fixes and scheduler-aware primitives; low risk and beneficial.


92-92: logr v1.4.3 bump looks good

Minor patch; no breaking changes expected.


134-134: klauspost/compress v1.18.0 bump approved

Performance and security improvements; no API break expected for indirect use.


223-227: Prometheus client and deps upgraded — LGTM

These versions are compatible and widely used; indirect only, so impact is minimal.


251-251: Core OpenTelemetry bump to v1.37.0 — LGTM

Brings in recent fixes and features. Assuming tests are green (as noted), this should be safe.

Also applies to: 255-258


264-269: x/crypto, x/net, x/sys, x/term, x/text bumps — approved

Security and bug-fix updates; no code changes required here.


276-276: google.golang.org/protobuf v1.36.6 — approved

Patch-level update, safe and desirable.

@MicBun MicBun merged commit 477244a into main Aug 15, 2025
5 of 6 checks passed
@MicBun MicBun deleted the chore/release-blacklist branch August 15, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants