Speedup and reduce memory usage in Normalize#426
Merged
soumith merged 1 commit intotorch:masterfrom Oct 13, 2015
Merged
Conversation
It's almost 40x faster on CPU, and doesn't use extra memory. Should be faster on GPU as well
Contributor
Author
|
Just did a quick test on the GPU, backward seems to be much faster than the previous version as well. |
Contributor
|
Hi, I ran @ffmpbgrnn's test from #341 for some simple profiling of this PR on a Tesla K40 GPU and 3.70GHz CPU. The speedup is amazing! require 'nn'
require 'cutorch'
require 'cunn'
local module = nn.Normalize(2):cuda()
module:fastMode(false)
local input = torch.rand(64, 2400):cuda()
local t = torch.Timer()
for i = 1, 100 do
module:forward(input)
module:backward(input, input)
print(i)
end
print(t:time().real/100)Current Master
This PR
|
Member
|
this is super awesome. If unit tests pass, and it's exactly the same implementation as before, why not!!! |
soumith
added a commit
that referenced
this pull request
Oct 13, 2015
Speedup and reduce memory usage in Normalize
bamos
added a commit
to cmusatyalab/openface
that referenced
this pull request
Oct 13, 2015
torch/nn#426, by @fmassa Also change from 50 -> 500 runs.
SuperAI520
added a commit
to SuperAI520/Open-Face-Recognition
that referenced
this pull request
Dec 2, 2024
torch/nn#426, by @fmassa Also change from 50 -> 500 runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's almost 40x faster on CPU, and doesn't use extra memory. Should
be faster on GPU as well, but I haven't benchmarked.
b1*b2of size(n,d,d), rearrange the computations to avoid creating this huge matrix which was eating all the memory.forwardandbackwardsupports varying dimensionality (which wasn't the case before because of theeyematrix)Should be of interest to @ffmpbgrnn and @bamos.