Skip to content

fixes issue 280 #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2019
Merged

fixes issue 280 #436

merged 2 commits into from
Jan 15, 2019

Conversation

sumitdaga
Copy link
Contributor

No description provided.

@standlove
Copy link
Collaborator

please check my response there as well:
please update the message to use correct plural forms as well (e.g. 1 row is, 2 rows are)
make sure the message is: 1 row is failed or 2 rows are failed.

@sumitdaga
Copy link
Contributor Author

updated!

@standlove standlove merged commit 49a676d into master Jan 15, 2019
@standlove standlove deleted the issue-280 branch January 15, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumitdaga @standlove