Dont set GMT+0 timezone in RollingCalendar if no timezone is given (fixes #213)#221
Merged
tony19 merged 2 commits intotony19:mainfrom Nov 6, 2022
veN1337:fix-daily-rollover-default-timezone
Merged
Dont set GMT+0 timezone in RollingCalendar if no timezone is given (fixes #213)#221tony19 merged 2 commits intotony19:mainfrom veN1337:fix-daily-rollover-default-timezone
tony19 merged 2 commits intotony19:mainfrom
veN1337:fix-daily-rollover-default-timezone
Conversation
and use default super contructor of GregorianCalendar to use system default timezone
using hosts default timezone and locale broke some static tests
Repository owner
deleted a comment from
veN1337
Nov 6, 2022
Repository owner
deleted a comment from
veN1337
Nov 6, 2022
tony19
approved these changes
Nov 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the timezone to GMT(+0) if no timezone is given, leads to daily rollover at midnight GMT+0 instead of midnight of the systems timezone.
Calling the default super contructor of GregorianCalendar instead of the one with a TimeZone parameter uses the systems default timezone and locale.
This fixes #213 and reverts commit 446eb7c