Use of EXT_DIR with Android API 29#208
Merged
tony19 merged 4 commits intotony19:masterfrom Nov 7, 2019
roedll:api-29-extdir
Merged
Use of EXT_DIR with Android API 29#208tony19 merged 4 commits intotony19:masterfrom roedll:api-29-extdir
tony19 merged 4 commits intotony19:masterfrom
roedll:api-29-extdir
Conversation
…grade to API 29 for Travis and Robolectric
Contributor
Author
|
Can anyone please help me with fixing the Travis build? |
Contributor
Author
|
Seems to work now... ;-) |
tony19
requested changes
Nov 5, 2019
Owner
tony19
left a comment
tony19
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just a few minor requests.
tony19
requested changes
Nov 5, 2019
logback-android/src/main/java/ch/qos/logback/core/android/AndroidContextUtil.java
Outdated
Show resolved
Hide resolved
logback-android/src/main/java/ch/qos/logback/core/android/AndroidContextUtil.java
Show resolved
Hide resolved
tony19
approved these changes
Nov 7, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When resolving the "EXT_DIR" variable the method Environment.getExternalStorageDirectory() is used.
As of Android API 29 this method is useless and deprecated (see the docs for details).
This patch replaces the usages of "getExternalStorageDirectory" with the proposed alternative Context.getExternalFilesDir()