Skip to content

Update default.nix to newer nix's and sync version#121

Merged
bradjc merged 2 commits intomasterfrom
nix-support
May 14, 2025
Merged

Update default.nix to newer nix's and sync version#121
bradjc merged 2 commits intomasterfrom
nix-support

Conversation

@alevy
Copy link
Member

@alevy alevy commented May 14, 2025

This adds the necessary Python dependencies for newer versions of tocklodaer, updates the names of a nix dependency, and parses the Python _version.py file to get the package version number, to avoid replicating and stagnation.

alevy and others added 2 commits May 14, 2025 10:34
This adds the necessary Python dependencies for newer versions of
tocklodaer, updates the names of a nix dependency, and parses the Python
`_version.py` file to get the package version number, to avoid
replicating and stagnation.
@alevy
Copy link
Member Author

alevy commented May 14, 2025

After merging this, I would ask that we mint a minor version (0.14.1) so we can also use this in the nix expressions from other Tock repos.

def _reset(self):
db_len = len(self.storage_binary)
self.storage_binary = bytearray(b"\xFF" * db_len)
self.storage_binary = bytearray(b"\xff" * db_len)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not that it does anything, but is this change supposed to be in this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... you didn't do this..., this thing did: https://github.com/tock/tockloader/blob/master/.github/workflows/autoblack.yml

huh, it's a bit unfortunate that that tool looks at unchanged code, feels like it injects weird noise of unrelated changes into PRs... :/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was done automatically by some agent called autoblack, and I had no part in it (see the second commit, which was added not by me)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, they changed the style: psf/black#2916

@bradjc
Copy link
Contributor

bradjc commented May 14, 2025

Does nix have a way to just use our fancy new pyproject.toml?

@bradjc bradjc merged commit e61348b into master May 14, 2025
@alevy
Copy link
Member Author

alevy commented May 14, 2025

Does nix have a way to just use our fancy new pyproject.toml?

I think there is maybe kinda sorta something. Will look into it actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants