feat(Client): improve chat and widget tree#33
Draft
poirierlouis wants to merge 3 commits intotiltedphoques:mainfrom
Draft
feat(Client): improve chat and widget tree#33poirierlouis wants to merge 3 commits intotiltedphoques:mainfrom
poirierlouis wants to merge 3 commits intotiltedphoques:mainfrom
Conversation
Use 4 spaces of project instead of 2 spaces.
Add utilities for UTF8 string. Trim text of user's input before testing emptiness/sending message to the chat.
Define missing parent field in LibraryItem widgets of 'multiplayer_ui.inkwidget'. Looks like some widgets are still not yet correctly parented (RHT still logs errors).
poirierlouis
changed the title
Collaborator
Author
|
Currently adding a file validation for inkwidget in WKit to automatically validate and fix widgets relationship... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trim text of chat
Implemented:
Logger.reds.From
hello worldtohello world.Reparent widgets in
multiplayer_ui.inkwidgetImplemented:
Note: RHT still logs errors meaning some widgets are still missing a parent in
.inkwidget.