Skip to content

Update graph in sync#32

Merged
bors[bot] merged 1 commit intothree-rs:masterfrom
vitvakatu:fix_sync
Jun 18, 2017
Merged

Update graph in sync#32
bors[bot] merged 1 commit intothree-rs:masterfrom
vitvakatu:fix_sync

Conversation

@vitvakatu
Copy link
Member

@vitvakatu vitvakatu commented Jun 18, 2017

I think it was mistake not to call update_graph in sync().
Without this, NodeInfo doesn't contain actual info and sync() panics on scene_id assertion.

@kvark
Copy link
Collaborator

kvark commented Jun 18, 2017

Thanks!
bors r+

bors bot added a commit that referenced this pull request Jun 18, 2017
@bors
Merge #32
3ad7954 
32: Update graph in sync r=kvark

I think it was mistake not to call `update_graph` in `sync()`.
Without this, `NodeInfo` doesn't contain *actual* info and `sync()` panics on `scene_id` assertion.
@bors
Copy link
Contributor

bors bot commented Jun 18, 2017

Build succeeded

@bors bors bot merged commit c9ece22 into three-rs:master Jun 18, 2017
@vitvakatu vitvakatu deleted the fix_sync branch June 18, 2017 16:51
kvark pushed a commit that referenced this pull request Nov 10, 2017
@bors
Merge #32
0b3d39e 
32: Update graph in sync r=kvark

I think it was mistake not to call `update_graph` in `sync()`.
Without this, `NodeInfo` doesn't contain *actual* info and `sync()` panics on `scene_id` assertion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vitvakatu @kvark