audio: dai-zephyr: Fix unused variable warning #8723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaluta
requested review from
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
lgirdwood
approved these changes
Jan 10, 2024
dbaluta
force-pushed
the
fix_unused_warn
branch
from
67560e4 to
5be9f22
Compare
ranj063
approved these changes
Jan 10, 2024
iuliana-prodan
approved these changes
Jan 10, 2024
marc-hb
reviewed
Jan 10, 2024
Collaborator
There was a problem hiding this comment.
Why not just use a better C99 declaration and move it right after the already existing #if CONFIG_IPC_MAJOR_4? We're in 2024 now...
C89 declarations are ugly and the #ifdef makes it even uglier.
In case you're wondering: we have C99 declarations in plenty other places and they never caused any issue with any toolchain. This topic was discussed in
btian1
reviewed
Jan 11, 2024
src/audio/dai-zephyr.c
Outdated
| } else { | ||
| #if CONFIG_IPC_MAJOR_4 | ||
| struct list_item *sink_list; | ||
| #endif |
Contributor
There was a problem hiding this comment.
echo Marc, please move line 259 after line 270, this will make code looks more integrity.
Collaborator
|
@dbaluta can you check, fix is good, but moving the declaration down avoids adding an ifdef... |
Move sink_list under CONFIG_IPC_MAJOR_4 in order to avoid the following variable unused warning:
$ sof/src/audio/dai-zephyr.c: In function 'dai_dma_cb':
$ sof_dir/sof/src/audio/dai-zephyr.c:259:35: warning: unused variable 'sink_list' [-Wunused-variable]
259 | struct list_item *sink_list;
| ^~~~~~~~~
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
dbaluta
force-pushed
the
fix_unused_warn
branch
from
5be9f22 to
ceea32c
Compare
Collaborator
Author
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard sink_list in order to avoid the following variable unused warning:
$ sof/src/audio/dai-zephyr.c: In function 'dai_dma_cb': $ sof_dir/sof/src/audio/dai-zephyr.c:259:35: warning: unused variable 'sink_list' [-Wunused-variable]
259 | struct list_item *sink_list;
| ^~~~~~~~~