Fix json_decode associative argument consistency with PHP#436
Closed
dpi wants to merge 1 commit intothecodingmachine:masterfrom
Closed
Fix json_decode associative argument consistency with PHP#436dpi wants to merge 1 commit intothecodingmachine:masterfrom
json_decode associative argument consistency with PHP#436dpi wants to merge 1 commit intothecodingmachine:masterfrom
Conversation
Contributor
Author
|
Similar to #376 |
dpi
changed the title
associative argument consistency with PHPjson_decode associative argument consistency with PHP
Collaborator
|
cherry-picked with #473 thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like to use named arguments with
\json_decode(), particularly with theassociativeargument.e.g.
\json_decode($json, associative: true);Switching to use
thecodingmachine/safecurrently necessitates switchingassociativetoassoc. This slows down migrations and introduces an inconsistency.We should fix the named argument of
\Safe\json_decodeso it has the same name as PHP.