Skip to content

Overwriting gitlab pre-recieve hook is bad #4

@spuder

Description

@spuder

In the example, the user is instructed to do a cp -R of the hooks directory.
Gitlab already uses the pre-receive, post-recieve and update webhooks, so overwriting them will cause problems. https://github.com/gitlabhq/gitlab-shell/tree/master/hooks

The alternatives are:

  1. Rewrite the puppet-lint and puppet validate commands in ruby and append them to the existing pre-recieve hook
  2. Put the puppet pre-receive bash script in a different file, then have the existing pre-receve hook call that script.

Maybe this should be clarified in the readme that you shouldn't overwrite these webhooks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions