Skip to content

fix: use local.zone fallback for replica region calculation #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2025
Merged

fix: use local.zone fallback for replica region calculation #760

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06f02b1
use local.zone fallback for replica region calculation
yasra002 Aug 12, 2025
20091bc
Merge branch 'main' into patch-3
yasra002 Aug 14, 2025
b00f73a
Merge branch 'main' into patch-3
imrannayer Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/postgresql/read_replica.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ resource "google_sql_database_instance" "replicas" {
project = var.project_id
name = each.value.name_override == null || each.value.name_override == "" ? "${local.instance_name}-replica${var.read_replica_name_suffix}${each.value.name}" : each.value.name_override
database_version = var.database_version
region = join("-", slice(split("-", lookup(each.value, "zone", var.zone)), 0, 2))
region = join("-", slice(split("-", lookup(each.value, "zone", local.zone)), 0, 2))
master_instance_name = google_sql_database_instance.default.name
deletion_protection = var.read_replica_deletion_protection
encryption_key_name = (join("-", slice(split("-", lookup(each.value, "zone", var.zone)), 0, 2))) == var.region ? null : each.value.encryption_key_name
encryption_key_name = (join("-", slice(split("-", lookup(each.value, "zone", local.zone)), 0, 2))) == var.region ? null : each.value.encryption_key_name

settings {
tier = lookup(each.value, "tier", null) == null ? var.tier : lookup(each.value, "tier", null)
Expand Down