fix: revert psc_config workaround - causes permanent drift #754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PR #718 was a temporary workaround for a provider bug, but now causes permanent drift:
Root cause: Workaround forces
psc_config
creation via["psc_disabled"]
, but GCP API omits the block when PSC is disabled → constant state mismatch.Solution
The original provider issue is fixed, reverting to the original behavior:
Testing Results
✅
psc_enabled = false
→ No drift, no unnecessary blocks✅
psc_enabled = true
→ Proper block creation✅ No PSC config → No drift, clean plans
Before:
terraform plan
always shows psc_config changesAfter:
terraform plan
shows "No changes" when appropriateReverts: #718 | Resolves: #750
What do you guys think?
Thanks.