Fixes the db name in transformer in case of openshift#661
Merged
tekton-robot merged 1 commit intotektoncd:mainfrom Mar 8, 2022
Merged
Fixes the db name in transformer in case of openshift#661tekton-robot merged 1 commit intotektoncd:mainfrom
tekton-robot merged 1 commit intotektoncd:mainfrom
Conversation
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XS
Contributor
|
/lgtm |
Contributor
|
The following is the coverage report on the affected files.
|
As we are adding `tekton-hub` as prefix so in the transformer we need to check with name as `tekton-hub-db` instead of db, so this patch changes check with name as `tekton-hub-db` Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
PuneetPunamiya
force-pushed
the
fix-db-name
branch
from
b978522 to
db3bf50
Compare
tekton-robot
added
size/S
Contributor
|
/lgtm |
vdemeester
approved these changes
Mar 8, 2022
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Contributor
|
/test pull-tekton-operator-integration-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we are adding
tekton-hubas prefix so in the transformerwe need to check with name as
tekton-hub-dbinstead of db,so this patch changes check with name as
tekton-hub-dbSigned-off-by: Puneet Punamiya ppunamiy@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes