Skip to content

Updates Hub components name by adding prefix as tekton-hub#654

Merged
tekton-robot merged 2 commits intotektoncd:mainfrom
PuneetPunamiya:add-tekton-hub-as-prefix
Mar 7, 2022
Merged

Updates Hub components name by adding prefix as tekton-hub#654
tekton-robot merged 2 commits intotektoncd:mainfrom
PuneetPunamiya:add-tekton-hub-as-prefix

Conversation

@PuneetPunamiya
Copy link
Member

@PuneetPunamiya PuneetPunamiya commented Mar 4, 2022

Signed-off-by: Puneet Punamiya ppunamiy@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 4, 2022
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 4, 2022
@PuneetPunamiya
Copy link
Member Author

PuneetPunamiya commented Mar 4, 2022

/hold
Keeping the patch in hold till we have Hub 1.7 released

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2022
@tekton-robot
Copy link
Contributor

tekton-robot commented Mar 4, 2022

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonhub_validation.go 96.2% 88.5% -7.7

nikhil-thomas
nikhil-thomas reviewed Mar 4, 2022
View reviewed changes
pkg/apis/operator/v1alpha1/tektonhub_defaults.go

if th.Spec.Db.DbSecretName == "" {
th.Spec.Db.DbSecretName = "db"
th.Spec.Db.DbSecretName = "tekton-hub-db"
Copy link
Member

@nikhil-thomas nikhil-thomas Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let us move the string tekton-hub- into a project level constant or a package level constant.

@nikhil-thomas
Copy link
Member

nikhil-thomas commented Mar 4, 2022

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2022
@PuneetPunamiya PuneetPunamiya force-pushed the add-tekton-hub-as-prefix branch from e937168 to 16f3a7e Compare March 7, 2022 02:57
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 7, 2022
@PuneetPunamiya
Updates Hub components name by adding prefix as tekton-hub
19b63f8 
Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
@PuneetPunamiya PuneetPunamiya force-pushed the add-tekton-hub-as-prefix branch from 16f3a7e to 19b63f8 Compare March 7, 2022 06:35
@PuneetPunamiya
Copy link
Member Author

PuneetPunamiya commented Mar 7, 2022

/retest

1 similar comment
@PuneetPunamiya
Copy link
Member Author

PuneetPunamiya commented Mar 7, 2022

/retest

@PuneetPunamiya
Copy link
Member Author

PuneetPunamiya commented Mar 7, 2022

/test pull-tekton-operator-integration-tests

@PuneetPunamiya
Copy link
Member Author

PuneetPunamiya commented Mar 7, 2022

retest

@nikhil-thomas
Copy link
Member

nikhil-thomas commented Mar 7, 2022

@PuneetPunamiya could you look into this

fetching | component: hub | version: v1.7.0
https://github.com/tektoncd/hub/releases/download/v1.7.0/db.yaml
url: https://github.com/tektoncd/hub/releases/download/v1.7.0/db.yaml
./hack/fetch-releases.sh: line 154: comp: unbound variable

https://tekton-releases.appspot.com/build/tekton-prow/pr-logs/pull/tektoncd_operator/654/pull-tekton-operator-integration-tests/1500812614161141760/

@PuneetPunamiya
Updates the fetch-release script and also sets the Hub CR status
6ed5bb1 
This patch updates the fetch-release script based on the new release
of hub i.e. it doesn't need to check for k8s platform as default
platform is k8s

This patch also sets the status of Hub CR when api secrets are
not properly configured

Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
@PuneetPunamiya
Copy link
Member Author

PuneetPunamiya commented Mar 7, 2022

@PuneetPunamiya could you look into this

fetching | component: hub | version: v1.7.0
https://github.com/tektoncd/hub/releases/download/v1.7.0/db.yaml
url: https://github.com/tektoncd/hub/releases/download/v1.7.0/db.yaml
./hack/fetch-releases.sh: line 154: comp: unbound variable

https://tekton-releases.appspot.com/build/tekton-prow/pr-logs/pull/tektoncd_operator/654/pull-tekton-operator-integration-tests/1500812614161141760/

Yeah i have updated the pr, actually i forgot that hub 1.7.0 was not release, now since it is released this should pass

@tekton-robot
Copy link
Contributor

tekton-robot commented Mar 7, 2022

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonhub/extension.go 24.0% 23.8% -0.2

@nikhil-thomas nikhil-thomas removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2022
@nikhil-thomas
Copy link
Member

nikhil-thomas commented Mar 7, 2022

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2022
@tekton-robot
Copy link
Contributor

tekton-robot commented Mar 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PuneetPunamiya
Copy link
Member Author

PuneetPunamiya commented Mar 7, 2022

/test pull-tekton-operator-integration-tests

@tekton-robot tekton-robot merged commit e3456ab into tektoncd:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@concaf concaf Awaiting requested review from concaf

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

1 more reviewer

@nikhil-thomas nikhil-thomas nikhil-thomas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nikhil-thomas nikhil-thomas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PuneetPunamiya @tekton-robot @nikhil-thomas