Improve Operator upgrade mechanism by nikhil-thomas · Pull Request #613 · tektoncd/operator

nikhil-thomas · 2022-02-03T12:40:37Z

Improve ReadyChecks for Pipelines and Triggers

Add mechanism to detect upgrade scenario in reconcilers and update
status with relevant messages

Minor fixes to ensure TektonAddon reconciler acts more predictably

Signed-off-by: Nikhil Thomas nikthoma@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

NONE

tekton-robot · 2022-02-03T13:08:53Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/initcontroller.go	Do not exist	0.0%
pkg/reconciler/openshift/tektonconfig/extension/addon.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/pipeline/pipeline.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/trigger/trigger.go	72.1%	71.2%	-0.9

tekton-robot · 2022-02-03T13:18:53Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/initcontroller.go	Do not exist	0.0%
pkg/reconciler/openshift/tektonconfig/extension/addon.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/pipeline/pipeline.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/trigger/trigger.go	72.1%	71.2%	-0.9

tekton-robot · 2022-02-03T13:29:00Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/initcontroller.go	Do not exist	0.0%

nikhil-thomas · 2022-02-03T13:37:43Z

@concaf @vdemeester
ready for review

tekton-robot · 2022-02-03T13:39:53Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/initcontroller.go	Do not exist	0.0%
pkg/reconciler/openshift/tektonconfig/extension/addon.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/pipeline/pipeline.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/trigger/trigger.go	72.1%	71.2%	-0.9

pkg/reconciler/common/common.go

tekton-robot · 2022-02-03T13:40:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot · 2022-02-03T13:43:48Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/initcontroller.go	Do not exist	0.0%
pkg/reconciler/openshift/tektonconfig/extension/addon.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/pipeline/pipeline.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/trigger/trigger.go	72.1%	71.2%	-0.9

pkg/reconciler/kubernetes/tektontrigger/tektontrigger.go

pkg/reconciler/openshift/tektonaddon/tektonaddon.go

tekton-robot · 2022-02-03T13:51:19Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/initcontroller.go	Do not exist	0.0%
pkg/reconciler/openshift/tektonconfig/extension/addon.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/pipeline/pipeline.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/trigger/trigger.go	72.1%	71.2%	-0.9

pkg/reconciler/shared/tektonconfig/tektonconfig.go

pkg/reconciler/kubernetes/tektonpipeline/tektonpipeline.go

sm43 · 2022-02-03T14:04:28Z

=========================================
==== TESTING IF GOLINT HAS BEEN DONE ====
=========================================
pkg/reconciler/kubernetes/tektoninstallerset/const.go:1: : import cycle not allowed in test (typecheck)
/*
==============================
==== GO LINT TESTS FAILED ====
==============================

lint check seems to be failing

LGTM !

pkg/reconciler/kubernetes/tektonpipeline/tektonpipeline.go

tekton-robot · 2022-02-04T06:57:58Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/initcontroller.go	Do not exist	0.0%
pkg/reconciler/openshift/tektonconfig/extension/addon.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/pipeline/pipeline.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/trigger/trigger.go	72.1%	71.2%	-0.9

tekton-robot · 2022-02-04T07:09:57Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/initcontroller.go	Do not exist	0.0%
pkg/reconciler/openshift/tektonconfig/extension/addon.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/pipeline/pipeline.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/trigger/trigger.go	72.1%	71.2%	-0.9

nikhil-thomas · 2022-02-04T07:14:48Z

/hold cancel

tekton-robot · 2022-02-04T07:26:51Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/initcontroller.go	Do not exist	0.0%
pkg/reconciler/openshift/tektonconfig/extension/addon.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/pipeline/pipeline.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/trigger/trigger.go	72.1%	71.2%	-0.9

concaf · 2022-02-04T09:18:04Z

/test pull-tekton-operator-integration-tests

nikhil-thomas · 2022-02-04T09:54:50Z

/hold

piyush-garg · 2022-02-04T10:38:08Z

/lgtm

tekton-robot · 2022-02-04T12:03:52Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/initcontroller.go	Do not exist	0.0%
pkg/reconciler/openshift/tektonconfig/extension/addon.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/pipeline/pipeline.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/trigger/trigger.go	72.1%	71.2%	-0.9

nikhil-thomas · 2022-02-04T12:16:48Z

/hold cancel

Improve ReadyChecks for Pipelines and Triggers Add mechanism to detect upgrade scenario in reconcilers and update status with relevant messages Minor fixes to ensure TektonAddon reconciler acts more predictably Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>

tekton-robot · 2022-02-04T12:34:51Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/initcontroller.go	Do not exist	0.0%
pkg/reconciler/openshift/tektonconfig/extension/addon.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/pipeline/pipeline.go	56.5%	56.7%	0.3
pkg/reconciler/shared/tektonconfig/trigger/trigger.go	72.1%	71.2%	-0.9

pradeepitm12

/lgtm

tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 3, 2022

tekton-robot requested review from piyush-garg and pradeepitm12 February 3, 2022 12:40

tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2022

nikhil-thomas force-pushed the fix/tektonaddon-upgrade branch from 8a0557c to 12f630c Compare February 3, 2022 13:06

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2022

nikhil-thomas force-pushed the fix/tektonaddon-upgrade branch from 12f630c to 65cd60f Compare February 3, 2022 13:16

nikhil-thomas force-pushed the fix/tektonaddon-upgrade branch from 65cd60f to 9173bc6 Compare February 3, 2022 13:27

nikhil-thomas force-pushed the fix/tektonaddon-upgrade branch from 9173bc6 to f22c38b Compare February 3, 2022 13:37

vdemeester approved these changes Feb 3, 2022

View reviewed changes

pkg/reconciler/common/common.go Show resolved Hide resolved

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2022

nikhil-thomas force-pushed the fix/tektonaddon-upgrade branch from f22c38b to 43603f5 Compare February 3, 2022 13:41

piyush-garg reviewed Feb 3, 2022

View reviewed changes

pkg/reconciler/kubernetes/tektontrigger/tektontrigger.go Outdated Show resolved Hide resolved

piyush-garg reviewed Feb 3, 2022

View reviewed changes

pkg/reconciler/openshift/tektonaddon/tektonaddon.go Outdated Show resolved Hide resolved

nikhil-thomas force-pushed the fix/tektonaddon-upgrade branch from 43603f5 to 4ba64b1 Compare February 3, 2022 13:49

piyush-garg reviewed Feb 3, 2022

View reviewed changes

pkg/reconciler/shared/tektonconfig/tektonconfig.go Outdated Show resolved Hide resolved

sm43 reviewed Feb 3, 2022

View reviewed changes

pkg/reconciler/kubernetes/tektonpipeline/tektonpipeline.go Show resolved Hide resolved

savitaashture reviewed Feb 3, 2022

View reviewed changes

pkg/reconciler/kubernetes/tektonpipeline/tektonpipeline.go Outdated Show resolved Hide resolved

savitaashture reviewed Feb 3, 2022

View reviewed changes

pkg/reconciler/kubernetes/tektonpipeline/tektonpipeline.go Show resolved Hide resolved

nikhil-thomas force-pushed the fix/tektonaddon-upgrade branch from 4ba64b1 to bf79a04 Compare February 4, 2022 06:32

tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 4, 2022

nikhil-thomas force-pushed the fix/tektonaddon-upgrade branch from 6a8ec39 to 303f800 Compare February 4, 2022 07:07

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2022

nikhil-thomas force-pushed the fix/tektonaddon-upgrade branch from 303f800 to 48d4149 Compare February 4, 2022 07:24

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2022

tekton-robot assigned piyush-garg Feb 4, 2022

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2022

nikhil-thomas force-pushed the fix/tektonaddon-upgrade branch from 48d4149 to 01a222c Compare February 4, 2022 12:01

tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 4, 2022

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2022

nikhil-thomas force-pushed the fix/tektonaddon-upgrade branch from 01a222c to 16ef7bd Compare February 4, 2022 12:32

tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 4, 2022

pradeepitm12 reviewed Feb 4, 2022

View reviewed changes

tekton-robot assigned pradeepitm12 Feb 4, 2022

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2022

tekton-robot merged commit e8f205b into tektoncd:main Feb 4, 2022

Conversation

nikhil-thomas commented Feb 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Submitter Checklist

Release Notes

Uh oh!

tekton-robot commented Feb 3, 2022

Uh oh!

tekton-robot commented Feb 3, 2022

Uh oh!

tekton-robot commented Feb 3, 2022

Uh oh!

nikhil-thomas commented Feb 3, 2022

Uh oh!

tekton-robot commented Feb 3, 2022

Uh oh!

Uh oh!

tekton-robot commented Feb 3, 2022

Uh oh!

tekton-robot commented Feb 3, 2022

Uh oh!

Uh oh!

Uh oh!

tekton-robot commented Feb 3, 2022

Uh oh!

Uh oh!

Uh oh!

sm43 commented Feb 3, 2022

Uh oh!

Uh oh!

Uh oh!

tekton-robot commented Feb 4, 2022

Uh oh!

tekton-robot commented Feb 4, 2022

Uh oh!

nikhil-thomas commented Feb 4, 2022

Uh oh!

tekton-robot commented Feb 4, 2022

Uh oh!

concaf commented Feb 4, 2022

Uh oh!

nikhil-thomas commented Feb 4, 2022

Uh oh!

piyush-garg commented Feb 4, 2022

Uh oh!

tekton-robot commented Feb 4, 2022

Uh oh!

nikhil-thomas commented Feb 4, 2022

Uh oh!

tekton-robot commented Feb 4, 2022

Uh oh!

pradeepitm12 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

nikhil-thomas commented Feb 3, 2022 •

edited

Loading