Fix versioned clustertask getting deleted during upgrade#599
Merged
tekton-robot merged 1 commit intotektoncd:mainfrom Jan 28, 2022
Merged
Fix versioned clustertask getting deleted during upgrade#599tekton-robot merged 1 commit intotektoncd:mainfrom
tekton-robot merged 1 commit intotektoncd:mainfrom
Conversation
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
piyush-garg
force-pushed
the
fic_1962
branch
2 times, most recently
from
03e41b0 to
ebd4d1a
Compare
tekton-robot
added
size/L
This will fix the issue of versioned clustertask getting deleted during upgrade Now two installersets will be created for versioned and non version clustertask. There is new label getting added on versioned clustertask installerset having major and minor version details and the versioned clustertask installetset will only be deleted when there will be two of same minor and major version and installerset for latest operator version will be created. Eventually installerset will remain there of different operator minor version only ending in versioned clustertask to stay on cluster
vdemeester
approved these changes
Jan 28, 2022
tekton-robot
added
the
approved
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhil-thomas, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix the issue of versioned clustertask getting
deleted during upgrade
Now two installersets will be created for versioned and
non version clustertask. There is new label getting added
on versioned clustertask installerset having major and minor version
details and the versioned clustertask installetset will only be deleted
when there will be two of same minor and major version and installerset
for latest operator version will be created.
Eventually installerset will remain there of different operator minor version
only ending in versioned clustertask to stay on cluster
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes