Skip to content

Schedule tkn serve cli pod also on infra node#544

Merged
tekton-robot merged 1 commit intotektoncd:mainfrom
piyush-garg:add_serve_cli_node_tranform
Dec 9, 2021
Merged

Schedule tkn serve cli pod also on infra node#544
tekton-robot merged 1 commit intotektoncd:mainfrom
piyush-garg:add_serve_cli_node_tranform

Conversation

@piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Dec 7, 2021

This will add the field in the tekton addon CRD so that nodeselector
and tolerations can be passed to tekton addon cr from config cr and
use those values in scheduling the tkn serve cli pod using already
existing transformer

Added the hash value in the installerset and if it changes, it again
read the manifest and assign to the installerset

This will fix tkn serve cli pod not getting scheduled on infra nodes
if configured in subscription and config CR

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Schedule tkn serve cli pod also on infra node

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 7, 2021
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 7, 2021
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/extension/addon.go 59.3% 56.5% -2.9

@piyush-garg piyush-garg force-pushed the add_serve_cli_node_tranform branch from b9a135f to d486784 Compare December 7, 2021 07:33
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/extension/addon.go 59.3% 56.5% -2.9

@piyush-garg piyush-garg force-pushed the add_serve_cli_node_tranform branch from d486784 to 964423e Compare December 7, 2021 08:55
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/extension/addon.go 59.3% 56.5% -2.9

@nikhil-thomas
Copy link
Member

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2021
@piyush-garg
Copy link
Contributor Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2021
@piyush-garg piyush-garg force-pushed the add_serve_cli_node_tranform branch from 964423e to 9f8a5d2 Compare December 9, 2021 04:51
@piyush-garg
Copy link
Contributor Author

/hold cancel

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2021
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/extension/addon.go 59.3% 56.5% -2.9

@piyush-garg piyush-garg force-pushed the add_serve_cli_node_tranform branch from 9f8a5d2 to f804c20 Compare December 9, 2021 05:01
This will add the field in the tekton addon CRD so that nodeselector
and tolerations can be passed to tekton addon cr from config cr and
use those values in scheduling the tkn serve cli pod using already
existing transformer

Added the hash value in the installerset and if it changes, it again
read the manifest and assign to the installerset

This will fix tkn serve cli pod not getting scheduled on infra nodes
if configured in subscription and config CR
@piyush-garg piyush-garg force-pushed the add_serve_cli_node_tranform branch from f804c20 to f7e8cd3 Compare December 9, 2021 05:05
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/extension/addon.go 59.3% 56.5% -2.9

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/extension/addon.go 59.3% 56.5% -2.9

@nikhil-thomas
Copy link
Member

✔️ lgtm

@sm43
Copy link
Member

sm43 commented Dec 9, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2021
@tekton-robot tekton-robot merged commit 63064cb into tektoncd:main Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants