Fix Webhook configuration creation bug on K8s#536
Merged
tekton-robot merged 1 commit intotektoncd:mainfrom Dec 1, 2021
Merged
Conversation
Removes duplicate definition of the webhook secret from kodata The installerset was stuck in error status as the same secret resource was being created by 2 entities (make apply and later by webhook deployment). This was correctly handled on OpenShift kodata. Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
tekton-robot
added
the
release-note
tekton-robot
added
the
size/S
Member
|
/lgtm |
Comment on lines
-15
to
-24
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: tekton-operator-webhook-certs | ||
| labels: | ||
| name: tekton-operator-webhook | ||
| app: tekton-operator | ||
| # The data is populated at install time. | ||
|
|
||
| --- |
Contributor
There was a problem hiding this comment.
@nikhil-thomas its now handled here https://github.com/tektoncd/operator/blob/main/config/webhooks/webhook-secret.yaml right
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes duplicate definition of the webhook secret from kodata
The installerset was stuck in error status as the same secret resource
was being created by 2 entities (make apply and later by webhook
deployment). This was correctly handled on OpenShift kodata.
Signed-off-by: Nikhil Thomas nikthoma@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes