Skip to content

Hook more context.Context everywhere…#533

Merged
tekton-robot merged 1 commit intotektoncd:mainfrom
vdemeester:ctx-everywhere
Dec 1, 2021
Merged

Hook more context.Context everywhere…#533
tekton-robot merged 1 commit intotektoncd:mainfrom
vdemeester:ctx-everywhere

Conversation

@vdemeester
Copy link
Member

Changes

This allow to share more things, react better and be more consistent
across the code base.

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/kind cleanup

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 26, 2021
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 26, 2021
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2021
This allow to share more things, react better and be more consistent
across the code base.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2021
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas, pradeepitm12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit d5a8fd2 into tektoncd:main Dec 1, 2021
@vdemeester vdemeester deleted the ctx-everywhere branch December 1, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants