Skip to content

[OpenShift] Adds SCC predicate in TektonInstallerSet#482

Merged
tekton-robot merged 1 commit intotektoncd:mainfrom
sm43:scc-predicate
Nov 2, 2021
Merged

[OpenShift] Adds SCC predicate in TektonInstallerSet#482
tekton-robot merged 1 commit intotektoncd:mainfrom
sm43:scc-predicate

Conversation

@sm43
Copy link
Member

@sm43 sm43 commented Nov 2, 2021

TektonInstallerSet was missing SecurityContextConstraints predicate
due to which scc was not getting installed in OpenShift, this adds it.

Signed-off-by: Shivam Mukhade smukhade@redhat.com

/cc @vdemeester @nikhil-thomas

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

TektonInstallerSet was missing SecurityContextConstraints predicate
due to which scc was not getting installed in OpenShift, this adds it.

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 2, 2021
@nikhil-thomas
Copy link
Member

/lgtm
/approve

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 2, 2021
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [nikhil-thomas,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit eee2a0e into tektoncd:main Nov 2, 2021
@sm43 sm43 deleted the scc-predicate branch August 19, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants