[cherry-pick/v0.50.x] Mutate tekton-pipelines namespace for ClusterRoles#477
Merged
tekton-robot merged 1 commit intotektoncd:release-v0.50.xfrom Oct 28, 2021
Merged
Conversation
This adds a new transformer that mutate tekton-pipelines namespaces references in ClusterRoles rules to use the targetNamespace. This fixes the webhook errors on OpenShift or if the operator uses a different `targetNamespace` than `tekton-pipelines` Signed-off-by: Vincent Demeester <vdemeest@redhat.com> (cherry picked from commit 132c03b) Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
tekton-robot
added
the
size/M
Member
|
/lgtm |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhil-thomas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This adds a new transformer that mutate tekton-pipelines namespaces
references in ClusterRoles rules to use the targetNamespace.
This fixes the webhook errors on OpenShift or if the operator uses a
different
targetNamespacethantekton-pipelinesSigned-off-by: Vincent Demeester vdemeest@redhat.com
(cherry picked from commit 132c03b)
Signed-off-by: Vincent Demeester vdemeest@redhat.com
Cherry picks of #474
/cc @nikhil-thomas @sm43
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes